Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix todo #3713

Merged
merged 5 commits into from
Aug 23, 2021
Merged

test: fix todo #3713

merged 5 commits into from
Aug 23, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

tests

Motivation / Use-Case

fix todo in tests

Breaking Changes

No

Additional Info

Same os is not supported ip v6 so we fallback on ::

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #3713 (696a705) into master (4831f58) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3713   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files          15       15           
  Lines        1327     1327           
  Branches      460      460           
=======================================
  Hits         1237     1237           
  Misses         83       83           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4831f58...696a705. Read the comment docs.

@alexander-akait alexander-akait merged commit 4eb1ab8 into master Aug 23, 2021
@alexander-akait alexander-akait deleted the test-fix-todo branch August 23, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant