perf: remove assets from stats #3905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markjm
requested review from
alexander-akait,
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
|
cc @alexander-akait here are the changes with snippets of the traces. Saves a little under 100ms in my project |
| } | ||
|
|
||
| static get DEFAULT_STATS() { | ||
| return { | ||
| all: false, | ||
| hash: true, | ||
| assets: true, | ||
| assets: false, |
There was a problem hiding this comment.
we can omit this because all: false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
no, I am willing to, but am unsure exactly where this functionality is currently being tests
Motivation / Use-Case
stats.toJson call is more expensive with
assetsenabled, but it is not needed. Instead, we still keep track of hash so as to keep to only refresh the page when there is a real change (saving file with no changes will not refresh the page)Before
After
Breaking Changes
none
Additional Info