test: remove duplicate tests #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested review from
alexander-akait,
anshumanv,
hiroppy and
knagaitsev
as code owners
snitin315
commented
Dec 25, 2021
| }); | ||
| }); | ||
|
|
||
| it("add hot-only option", (done) => { |
There was a problem hiding this comment.
e2e tests already present for hot: true and hot: 'only' - https://github.com/webpack/webpack-dev-server/blob/master/test/e2e/hot-and-live-reload.test.js
snitin315
commented
Dec 25, 2021
| }); | ||
|
|
||
| // TODO: remove this after plugin support is published | ||
| it("should create and run server with old parameters order and log deprecation warning", (done) => { |
There was a problem hiding this comment.
E2E test already present.
webpack-dev-server/test/e2e/api.test.js
Line 398 in 317e4b9
Codecov Report
@@ Coverage Diff @@
## master #4136 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 14 14
Lines 1540 1540
Branches 589 589
=======================================
Hits 1421 1421
Misses 110 110
Partials 9 9 Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Dec 25, 2021
|
@snitin315 Feel free to merge when CI will green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
remove duplicate tests.
Breaking Changes
None
Additional Info
No