Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix #4143

Merged
merged 10 commits into from
Dec 29, 2021
Merged

ci: fix #4143

merged 10 commits into from
Dec 29, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no need

Motivation / Use-Case

update deps + fix ci

Breaking Changes

No

Additional Info

I want to stability our ci too, so let's look how our tests will work after update

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #4143 (978101b) into master (f6bc644) will not change coverage.
The diff coverage is n/a.

❗ Current head 978101b differs from pull request most recent head 60e6678. Consider uploading reports for the commit 60e6678 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4143   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files          14       14           
  Lines        1543     1543           
  Branches      590      590           
=======================================
  Hits         1424     1424           
  Misses        110      110           
  Partials        9        9           
Impacted Files Coverage Δ
lib/Server.js 93.73% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6bc644...60e6678. Read the comment docs.

@alexander-akait
Copy link
Member Author

Found a problem

@alexander-akait
Copy link
Member Author

https tests are broken on macos... maybe due different puppeteer builds on different os or different system libraries...

@alexander-akait
Copy link
Member Author

Still failed, I will look at this tomorrow, let's do patch release

@alexander-akait alexander-akait merged commit 90a96f7 into master Dec 29, 2021
@alexander-akait alexander-akait deleted the ci-fix branch December 29, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant