test: move away from magicHTML in favor of HTMLGeneratorPlugin
#4186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested review from
alexander-akait,
anshumanv,
hiroppy and
knagaitsev
as code owners
snitin315
force-pushed
the
test/use-html-generator-plugin
branch
from
117f6b7
to
aa9c621
Compare
snitin315
force-pushed
the
test/use-html-generator-plugin
branch
from
aa9c621
to
5da2e81
Compare
Codecov Report
@@ Coverage Diff @@
## master #4186 +/- ##
==========================================
+ Coverage 92.34% 92.47% +0.12%
==========================================
Files 14 14
Lines 1541 1541
Branches 590 590
==========================================
+ Hits 1423 1425 +2
+ Misses 109 107 -2
Partials 9 9
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
@snitin315 Do we migrate from it in all tests? Just comment magicHTML logic in code and run test locally to catch all cases
|
I believe few tests are yet to be migrated. They may require more refactor. I will update them separate. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No. Refactor them.
Motivation / Use-Case
Refactor tests to move away from magicHTML feature.
Some tests needs more refactor I will update them in separate PRs.
Breaking Changes
None.
Additional Info
No