Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose socket client for external integrations #4324

Closed
wants to merge 1 commit into from

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

Fix #4261
Fix #4304

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #4324 (13da56b) into master (f63ca57) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4324      +/-   ##
==========================================
+ Coverage   92.05%   92.18%   +0.12%     
==========================================
  Files          15       15              
  Lines        1549     1549              
  Branches      591      591              
==========================================
+ Hits         1426     1428       +2     
+ Misses        114      112       -2     
  Partials        9        9              
Impacted Files Coverage Δ
lib/Server.js 93.66% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85bbeea...13da56b. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add test

@snitin315
Copy link
Member Author

How should we test this? Just check if this is exported?

@alexander-akait
Copy link
Member

Yep, just create puppeteer test and try to get client from external script

@snitin315
Copy link
Member Author

@alexander-akait not sure how to get client from an external script. Can you give example?

@alexander-akait
Copy link
Member

Just import dev server client and test value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Socket Client for external integrations
2 participants