Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: security problem with sockjs #4482

Merged
merged 1 commit into from Jun 13, 2022
Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jun 13, 2022

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Existing

Motivation / Use-Case

Allow to setup https://github.com/nfriedly/express-rate-limit package (and other) to prevent a denial of service attack, We don't setup rate limits by default, because we are a development server and this is not applicable for us, but you can setup rate limit middleware using https://webpack.js.org/configuration/dev-server/#devserversetupmiddlewares

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #4482 (587baf8) into master (90488f1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4482      +/-   ##
==========================================
- Coverage   92.19%   92.18%   -0.01%     
==========================================
  Files          16       16              
  Lines        1601     1600       -1     
  Branches      604      604              
==========================================
- Hits         1476     1475       -1     
  Misses        114      114              
  Partials       11       11              
Impacted Files Coverage Δ
lib/Server.js 93.65% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90488f1...587baf8. Read the comment docs.

@alexander-akait alexander-akait merged commit 049b153 into master Jun 13, 2022
16 of 17 checks passed
@alexander-akait alexander-akait deleted the fix-security-problem branch Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants