Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: udpate jest #4810

Merged
merged 3 commits into from
Apr 14, 2023
Merged

chore: udpate jest #4810

merged 3 commits into from
Apr 14, 2023

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Apr 8, 2023

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No.

Motivation / Use-Case

Upgrade jest + typescript.

Breaking Changes

No.

Additional Info

No

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.13 ⚠️

Comparison is base (74fe96c) 92.20% compared to head (5cc0bcd) 92.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4810      +/-   ##
==========================================
- Coverage   92.20%   92.07%   -0.13%     
==========================================
  Files          15       15              
  Lines        1539     1539              
  Branches      573      573              
==========================================
- Hits         1419     1417       -2     
- Misses        111      113       +2     
  Partials        9        9              

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

lib/Server.js Outdated Show resolved Hide resolved
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, I am afraid it can break types for other developers, we need to investigate it

@snitin315
Copy link
Member Author

Hmm, could be a bug in typescript too. I'll check

@snitin315 snitin315 changed the title chore: udpate jest & typescript chore: udpate jest Apr 14, 2023
@snitin315
Copy link
Member Author

Let's upgrade ts separately

@alexander-akait alexander-akait merged commit 2c1862f into next Apr 14, 2023
@alexander-akait alexander-akait deleted the fix/major-deps-upgrade branch April 14, 2023 13:41
snitin315 added a commit that referenced this pull request May 6, 2023
snitin315 added a commit that referenced this pull request May 25, 2023
snitin315 added a commit that referenced this pull request Jan 13, 2024
alexander-akait pushed a commit that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants