feat: remove caret in @types/ws package version #4894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JansenMoscol
requested review from
alexander-akait,
hiroppy,
snitin315 and
anshumanv
as code owners
|
|
|
Why? |
|
Because I have error with version 8.5.5 node_modules/@types/ws/index.d.ts(328,18): error TS2315: Type 'Server' is not generic. |
|
Please fix your typescript code, it is transitive dependency |
|
It's not my code, the new version @types/ws 8.5.5 broke the library. You can try doing a clean install. |
|
@JansenMoscol In this case please open an issue in |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have error with version 8.5.5
node_modules/@types/ws/index.d.ts(328,18): error TS2315: Type 'Server' is not generic.