-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add visual progress indicators #5186
feat: add visual progress indicators #5186
Conversation
Thank you for you PR, can you fix lint? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5186 +/- ##
===========================================
- Coverage 90.29% 56.19% -34.11%
===========================================
Files 15 11 -4
Lines 1577 1413 -164
Branches 601 555 -46
===========================================
- Hits 1424 794 -630
- Misses 140 507 +367
- Partials 13 112 +99 ☔ View full report in Codecov by Sentry. |
Should be fixed. @alexander-akait the re-run of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with it, but I am afraid some developers still can use our client in old browsers, so shadow dom can't work, let's add a check and don't run this code
@alexander-akait will do, sorry for moving so slow on this. As an alternative, we could just expose some explicit API (or tell folks to lean on the |
@issacgerges Yeah, we can, but I am fine with your solution, just let's add additional check to avoid problems with old browsers |
492a36b
to
0c855ac
Compare
Updated
|
@@ -236,6 +239,18 @@ const onSocketMessage = { | |||
); | |||
} | |||
|
|||
if (isProgressSupported()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move defineProgressElement
after this check to avoid extra checks and have customElements.define("wds-progress", WebpackDevServerProgress);
only in this function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, let's do one small improvement and we can merge
Thank you, good work ⭐ |
For Bugs and Features; did you add new tests?
No, could use guidance if they are needed
Motivation / Use-Case
Adds built-in visual progress indicators to
webpack-dev-server
Breaking Changes
No breaking changes
Additional Info