Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Describe that --inline toggles livereload #596

Merged
merged 1 commit into from
Sep 12, 2016
Merged

CLI: Describe that --inline toggles livereload #596

merged 1 commit into from
Sep 12, 2016

Conversation

ajoslin
Copy link
Contributor

@ajoslin ajoslin commented Sep 7, 2016

What kind of change does this PR introduce?

  • Bugfix (CLI)
  • Feature (CLI)

What is the current behavior? (You can also link to an open issue here)

webpack-dev-server --help | grep live doesn't help me, and webpack-dev-server --help | grep reload doesn't help me.

What is the new behavior?

Both webpack-dev-server --help | grep live and webpack-dev-server --help | grep reload help me

Does this PR introduce a breaking change?

  • Yes
  • No

@ajoslin
Copy link
Contributor Author

ajoslin commented Sep 7, 2016

cc @gdi2290

@SpaceK33z
Copy link
Member

I'm not sure about this. It's technically not true that setting inline to false disables live reload. If you use the iframe modus (by going to http://localhost:8080/webpack-dev-server/), you still have live reload. Also, if you manually include the client script, you also have live reload.

@SpaceK33z
Copy link
Member

Something like "Set to false to disable including client scripts" would be more correct I think.

@ajoslin
Copy link
Contributor Author

ajoslin commented Sep 11, 2016

Alright. Could we explicitly say that "client scripts" includes livereload?

Perhaps:

Inline mode (set to false to disable including client scripts like livereload)

@SpaceK33z
Copy link
Member

Okay, fair enough. It's just that it's important to know that using --inline false does not mean that live-reload is disabled per definition.

@ajoslin
Copy link
Contributor Author

ajoslin commented Sep 11, 2016

I understand that isn't exactly what it does. Maybe it would be better to have an option just for livereload? It's a very reasonable thing to want to disable IMO, and most tools like this have an option for it.

@SpaceK33z
Copy link
Member

That's already possible, using --lazy :). If you update the PR with the text you suggested above, I'll merge this.

@ajoslin
Copy link
Contributor Author

ajoslin commented Sep 12, 2016

👍 Done

@SpaceK33z SpaceK33z merged commit 325ef59 into webpack:master Sep 12, 2016
@SpaceK33z
Copy link
Member

Thanks!

@ajoslin ajoslin deleted the patch-1 branch September 12, 2016 10:30
@ajoslin
Copy link
Contributor Author

ajoslin commented Sep 12, 2016

👌 And thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants