sanity check that conn exists on connection #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an edge case where null is passed (and aborts the server) on a new connection if all handles are occupied. I am able to reliably trigger this by rapidly refreshing on a page in development.
SpaceK33z
requested changes
Oct 5, 2016
|
The check and return now happen immediately, and the spacing issue is resolved. |
SpaceK33z
approved these changes
Oct 5, 2016
|
Thanks! |
SpaceK33z
pushed a commit
that referenced
this pull request
Oct 6, 2016
This prevents an edge case where null is passed (and aborts the server) on a new connection if all handles are occupied. I am able to reliably trigger this by rapidly refreshing on a page in development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low-impact bug fix that prevents an edge case where null is passed (and consequently aborts the server, which is the current behaviour) on a new connection if all handles are occupied.
I am able to reliably trigger this by rapidly refreshing on a page in development.