Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watch-content-base option #649

Merged
merged 2 commits into from
Oct 11, 2016
Merged

Add watch-content-base option #649

merged 2 commits into from
Oct 11, 2016

Conversation

charlespwd
Copy link
Contributor

@charlespwd charlespwd commented Oct 11, 2016

Please check if the PR fulfills these requirements

  • An example has been added or updated in examples/ (for features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Feature

What is the current behavior? (You can also link to an open issue here)
Currently, if a file changes under the content-base, nothing happens. #350

What is the new behavior?
With the --watch-content-base option, file changes in the content-base will trigger a full reload.

Does this PR introduce a breaking change?

  • No

Fixes #350. If/when this gets merged. We should update the official docs.

Copy link
Member

@SpaceK33z SpaceK33z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR!

I noticed the watcher isn't closed, so if you'd use the Node.js API, dev-server wouldn't stop properly. See Server.prototype.close.

@charlespwd
Copy link
Contributor Author

Thanks!

That's a very good point. Should be corrected now. Let me know if you want me to squash commits before you merge.

@SpaceK33z SpaceK33z merged commit b1abc23 into webpack:master Oct 11, 2016
@SpaceK33z
Copy link
Member

Cool addition, thanks again :). Could you document this in the new webpack v2 docs? See devServer options.

@charlespwd
Copy link
Contributor Author

Sure thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev server does not reload when content-base files change
2 participants