Support for array of contentBase #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the type checking of `contentBase` for `webpack-dev-server.js` so that it can handle multiple `content-base` arguments.
|
|
Curly bracket on the same line
|
Thanks! Tested this by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the type checking of
contentBaseforwebpack-dev-server.jsso that it can handle multiplecontent-basearguments.What kind of change does this PR introduce?
Feature
Did you add or update the
examples/?No. This is minor so I don't think an example is needed.
Summary
I made this change because I need it on my personal project. Everything was ready but there was just a missing check so I added it.
Does this PR introduce a breaking change?
No breaking change at all.
Other information