Update source-map

[mattdsteele]

Hi! This applies the fix as identified in mozilla/source-map#247

I've got a project that fails to build with the TypeError: Cannot read property 'substr' of undefined error as outlined in the above link. Manually updating source-map resolves it, and unfortunately we can't build our project until webpack-sources uses this version.

Thanks!

[jsf-clabot]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   70.84%   70.84%           
=======================================
  Files          11       11           
  Lines         415      415           
  Branches       64       64           
=======================================
  Hits          294      294           
  Misses        121      121

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc3e33...a241715. Read the comment docs.

[Hotell]

any update on this? source-map-loader is unusable without this

[tomasdev]

Can we get this merged please??

See @Hotell above

[joshwiens]

Working on getting someone with access to land this & get it out to npm.

[TheLarkInn]

Hi so sorry about the delay on this @sokra and myself are catching up from a week off. Will try to deliver this tonight

[TheLarkInn]

https://github.com/webpack/webpack-sources/releases/tag/v1.0.2 Release'd and available on NPM. Sorry for the delay, and really appreciate the patience.

[wvankuipers]

This update seems to create another issue (noting this here as I'm not sure what is the root cause of this atm):

frontend/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:276
        throw new Error(
        ^

Error: original.line and original.column are not numbers -- you probably meant to omit the original mapping entirely and only map the generated position. If so, pass null for the original mapping instead of an object with empty or null values.
    at SourceMapGenerator_validateMapping [as _validateMapping] (frontend/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:276:15)
    at SourceMapGenerator_addMapping [as addMapping] (frontend/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:110:12)
    at frontend/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:72:17
    at Array.forEach (<anonymous>)
    at BasicSourceMapConsumer.SourceMapConsumer_eachMapping [as eachMapping] (frontend/node_modules/webpack-sources/node_modules/source-map/lib/source-map-consumer.js:157:14)
    at Function.SourceMapGenerator_fromSourceMap [as fromSourceMap] (frontend/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:48:24)
    at SourceMapSource.node (frontend/node_modules/webpack-sources/lib/SourceMapSource.js:32:35)
    at SourceMapSource.proto.sourceAndMap (frontend/node_modules/webpack-sources/lib/SourceAndMapMixin.js:30:18)
    at getTaskForFile (frontend/node_modules/webpack/lib/SourceMapDevToolPlugin.js:33:30)
    at chunk.files.forEach.file (frontend/node_modules/webpack/lib/SourceMapDevToolPlugin.js:91:21)

Reverting to v1.0.1 resolves this issue.

[TheLarkInn]

@mattdsteele are you aware of this? Should we submit an issue on the original source-map repo IRT this?

[mattdsteele]

Hmm; I haven't tried to reproduce. I'll see what's up.

[mattdsteele]

@wvankuipers I pulled down 1.0.2 in a couple of my projects but I wasn't able to reproduce what you're seeing. Based on what you've researched in #28 it appears to be source-map related, so that repo probably should be notified.

[joshwiens]

There is more information in the new issue created, it's not directly related to webpack-sources