Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop sudos from npm scripts? #1

Closed
bebraw opened this issue Jun 29, 2016 · 3 comments
Closed

Drop sudos from npm scripts? #1

bebraw opened this issue Jun 29, 2016 · 3 comments

Comments

@bebraw
Copy link
Contributor

bebraw commented Jun 29, 2016 •
edited

I noticed the npm scripts run through sudo. I don't think that's needed so might as well drop those bits.

You actually need to change the output path to form path: 'dist/build', at config/dev-config.js as otherwise it will try to write to root. One reason why sudoing isn't a good idea here.
@skipjack
Copy link
Collaborator

skipjack commented Jun 29, 2016 •
edited

Yea definitely should... I updated npm on my macbook and for some reason I'm getting an error when the local installation of Webpack tries to run mkdir. Just added it as a temporary fix, but I can try to debug the issue I was seeing later tonight.

@bebraw
Copy link
Contributor Author

bebraw commented Jun 29, 2016

It was probably that output.path. I think you'll find something at your system /dist/build. 👍

@bebraw bebraw closed this as completed in aa40c8b Jun 29, 2016
@skipjack
Copy link
Collaborator

skipjack commented Jul 4, 2016

@bebraw definitely just found and deleted a /dist folder in my system's root 😑

hzuhyb pushed a commit to hzuhyb/webpack.js.org that referenced this issue Feb 18, 2017
@madneal
Merge pull request webpack#1 from webpack-china/cn
7790aa5 
update from the origin
bebraw pushed a commit that referenced this issue Feb 26, 2017
@iroy2000
Merge pull request #1 from iroy2000/iroy2000-update-code-splitting-li…
c3d130a 
…b-md

Update code-splitting-libraries.md
bebraw pushed a commit that referenced this issue Mar 7, 2017
@scottdj92
Merge pull request #1 from scottdj92/update-support
1bda1b0 
Add new support page
simon04 pushed a commit that referenced this issue Apr 6, 2017
@redian
Update production-build.md (#1)
a22e518 
The comment was implying that a switch-case exists.
Checking the history, the switch-case was phased out on this commit: {7b83c19}
simon04 added a commit that referenced this issue Apr 6, 2017
@simon04
Merge pull request #1078 from redian/master
4ebe835 
Update production-build.md (#1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bebraw @skipjack