Guides Cleanup #1337
Guides Cleanup #1337
Conversation
We can choose to revive these later if they are requested by a significant amount of people. Also, especially the content in compatibility.md, is covered in other places (specifically in the `module-***.md` pages in `/api`).
This isn't really as much of an instructional as it is just information about different bundling and build systems.
|
@bebraw the build errors can be ignored as the unpkg 500 should now be fixed and the other one is just a missing edit link for the moved comparison guide. |
| @@ -109,7 +109,7 @@ __src/index.js__ | |||
| + | |||
| function component() { | |||
| var element = document.createElement('div'); | |||
|
|
|||
| - // Lodash, currently included via a script, is required for this line to work | |||
There was a problem hiding this comment.
This comment was on purpose, as it shows the user that in this case lodash is imported through a <script> tag, whereas later on it's imported by webpack.
Would you mind leaving it in (or maybe clarify it)?
There was a problem hiding this comment.
Ah yeah sorry about that. I think I either misunderstood or took this out accidentally. Will remove this change tonight.
There was a problem hiding this comment.
@TheDutchCoder just double-checked this. It's a bit confusing because your viewing a code block of the syntax highlighting language diff within a GitHub change diff. It tripped me up too when I first saw your comment. The diff from source tree is easier to understand:
It's only the blank line above that comment that changed. Just a minor editorconfig autofix 👍 . Your comment should remain untouched.
|
facepalm!
Thanks! :)
…On 26 June 2017 at 18:18, Greg Venech ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In content/guides/getting-started.md
<#1337 (comment)>
:
> @@ -109,7 +109,7 @@ __src/index.js__
+
function component() {
var element = document.createElement('div');
-
+
- // Lodash, currently included via a script, is required for this line to work
@TheDutchCoder <https://github.com/thedutchcoder> just double-checked
this. It's a bit confusing because your viewing a code block of the syntax
highlighting language diff within a GitHub change diff. It tripped me up
too when I first saw your comment. The diff from source tree is easier to
understand:
[image: image]
<https://user-images.githubusercontent.com/8988697/27562694-b844270c-5a9b-11e7-8fc0-d95d3ac2b20f.png>
It's only the blank line above that comment that changed. Just a minor
editorconfig autofix 👍 . Your comment should remain untouched.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1337 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABl0b4vRjxijiHGj-LgvGyl8tJM-2vehks5sIC44gaJpZM4OEUeh>
.
|
This pull request...
comparison.mdpage as it doesn't really fall under guidesSee the commit messages for more details on the "why" behind these changes.
cc @TheDutchCoder @jakearchibald