-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration Documentation #157
Conversation
@sokra hey I started working on this page as discussed with @bebraw in #25. I hadn't created a pull request yet as I'm not through the first pass (most of the way through Should I just scrap what I've done or do you want me to merge it into this PR? I should be done with the first pass in the next few days. If I merged it into here now, maybe others can review and take on some of the sections that I don't have as much knowledge on (there are TODOs throughout). I have a few ideas re structure too if you're interested. |
hi @gregvenech yes we should definitely merge our branches. You may notice that I've only layouted this page but haven't written any content yet. My idea was to add a code block with the configuration with a short explanation comment and a link to a more detailed section. This way you get a short overview. I also separated basic options from advanced options. |
Sounds good, yea I'll look at it more tonight and try to merge what I have into yours and follow your layout. |
@gregvenech merged both branches, we can continue working on that. |
Just added documentation for the rest of I like the idea with the linked code although I think the comments can be left out. I just came across something similar which might be another option, i.e. the hover behavior. A few other thoughts:
This prevents breaking up the option groups (like
|
What do you all think, @bebraw @sokra @TheLarkInn, about breaking template string substitutions into its own section and then referring to it from throughout the rest of the page? It seems like there's a lot of overlap between sections there so this could centralize and dedupe all that in one place. Again, maybe this is another one that can be broken out into it's own page. |
@gregvenech The way I see it, the function of this page is primarily to work as a quick reference (you want to see what this or that field does). So pushing more advanced info elsewhere could be worthwhile. Curious to hear what others think. |
@webpack/documentation-team I'm willing to break this up as soon as we decide how to we want to do that. I wanted people to have more time to review but maybe we should just start breaking it up first and then hit the TODOs page by page later. It seems like the original plan for most of this documentation was to split it up into the various pages under Either way though I'm willing to break this up and pass it on to others for more review and editing. |
What if we pushed the root level documentation for configuration to root level and even linked to it at the navigation? So you would end up with It's literally one of the most important pages so making it prominent wouldn't hurt. |
@bebraw that's exactly what I was thinking. If everyone's good with this I'll make this change tonight. |
|
Starting to break it out. Will finish this up, incorporate the new nav link, and merge tonight. |
Merged... we can review and edit each page in more granular pull requests now. |
Nice to see documentation for webpack progressing, however I, as a user, am disappointed that some content is being picked up from the existing documentation since it's been confusing to use time and again. While serving the documentation on a well layed out site might help with the confusion, I really doubt it's going to be any less frustrating to understand the various terminologies used. For example, sample the current description given for the
Note how various terms are used refer to similar things, without a distinction. Here's a brain dump of the questions that pop up in my mind -
|
I appreciate you expressing this. So we came to two conclusions:
Hopefully that clarifies things for you! |
Hi @pastelsky, thanks for your feedback. As @TheLarkInn mentioned, this is only the first pass at the configuration documentation and as I said in my last comment anyone is welcome to review, edit and PR any of these sections. As you can see I also left a lot of TODOs throughout these pages on the places that I think are too ambiguous/vague and those that I just didn't have enough background using to rewrite. The reason I merged this a bit early was because we were starting to see overlap between here and Concepts and it was somewhat unwieldy to review as one long document.
Agreed that some of these are ambiguous. Maybe something like Decide what directory to serve the site from (usually where your
They do not,
They are exclusive of each other. The issue you describe here is more about what the actual Hope this helps, again please feel free to edit and PR these changes and any others you might have. |
I agree with @pastelsky that mixing terms and examples is a problem. I really like the redux documentation that uses the TODO example throughout the documentation. This makes it easier to read different parts without switching contexts too often. |
Configuration Documentation
WIP