Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guides(HMR) remove namedModulesPlugin #2287

Merged
merged 2 commits into from
Jun 22, 2018
Merged

guides(HMR) remove namedModulesPlugin #2287

merged 2 commits into from
Jun 22, 2018

Conversation

EugeneHlushko
Copy link
Member

@EugeneHlushko EugeneHlushko commented Jun 22, 2018 •
edited
Loading

remove NamedModulesPlugin

Fixes #2279

@montogeek
Copy link
Member

Thanks!

@montogeek montogeek merged commit e6ec99b into master Jun 22, 2018
@montogeek montogeek deleted the issue/2279 branch June 22, 2018 17:37
@tbrisker
Copy link

tbrisker commented Jul 7, 2018

I think the namedModulesPlugin documentation itself shouldn't have been removed, it is enabled by default in development but should still be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montogeek montogeek montogeek approved these changes

@jeremenichelli jeremenichelli Awaiting requested review from jeremenichelli

Assignees
No one assigned
Labels
Plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EugeneHlushko @montogeek @tbrisker