New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize SVGs using svgo #2330
Optimize SVGs using svgo #2330
Conversation
Unfortunately we have no visual regression tests (we will, soon). Did you notice any weird change on sizes or something? |
Cool! You should consider happo.io. I bet @trotzig would help get you set up.
I did all of this visually in SVGOMG and it all looked very very similar to me, almost identical. You should be able to see these visually in GitHub by clicking on "View" when looking at the code changes. |
I ran a quick check with happo (only looking at icons, in Chrome) and it looks like most diffs are subtle: I worry a little about the sizing change for If you'd be interested, I could look at a more thorough happo integration. |
It looks like they are used in the footer. I grabbed their URLs from this PR and pasted them into the footer in my browser's inspector tool, and they look like they are still the same size. webpack.js.org/src/components/Footer/Footer.scss Lines 86 to 90 in ec844cb
|
I was able to reduce the size of most of the SVGs in this repo, which should give visitors a little bit better performance.
@montogeek do you want me to make any changes to this PR? |
Thanks! |
I was able to reduce the size of most of the SVGs in this repo, which
should give visitors a little bit better performance.