Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(concepts) use common formatting, provide more links, mention mod… #2472

Merged
merged 5 commits into from Sep 16, 2018

Conversation

EugeneHlushko
Copy link
Member

@EugeneHlushko EugeneHlushko commented Aug 28, 2018

  • mention mode in core concepts list
  • provide link for dependency graph
  • use common formatting instead of ** and *
  • duplicate links on the core concepts links for better user experience (quick nav)

@montogeek montogeek merged commit 020d6b9 into master Sep 16, 2018
@montogeek
Copy link
Member

Thanks!

@montogeek montogeek deleted the docs/concepts branch September 16, 2018 23:22
montogeek pushed a commit that referenced this pull request Sep 27, 2018
* fix(contribute) Use consistent plugin name in code snippet (#2496)

* fix(configuration) Fix small typo (#2511)

* docs(manifest) Corrections and small update to concept manifest page (#2504)

Small updates and corrections for manifest concepts page

* docs(concepts) Update dependency graph concepts page (#2495)

* docs(concepts) Update dependency graph concepts page

* docs(concepts) Dependency graph minor tweak

* docs(concepts) Use common formatting, provide more links, mention mod… (#2472)

* docs(concepts) use common formatting, provide more links, mention mode in core of the concepts

* docs(concepts) duplicate links on the list for better ux

* docs(concepts) forgot to add EugeneHlushko to contributors

* docs(configuration) Add externals examples (#2515)

Update the external docs with an example on how to combine the different syntaxes. 

I felt it was not clear how to achieve this from the existing docs.

* docs(plugins) Update Writing plugin and Plugin pattern page (#2200)

* Update Writing plugin and Plugin pattern page

* Fixed formatting issues

* Fix markdown lint issues

* Update plugin-patterns.md

* Update plugin-patterns.md

* docs(concepts) Using vendors as entry is not recommended (#2525)

* Using vendors as entry is not recommended

fixes webpack/webpack#6647

* add note about vendor entrypoints

* fix(guides) Correct misspelling and punctuation errors (#2513)

* Correct misspelling and punctuation errors

* Update build-performance.md

* docs(plugins): Add custom vendor chunks using RegEx example (#2518)

* docs(config): Example 3 - custom vendor chunk using RegEx

* docs(config): Example 3 SplitChunks Fenced blank added

* docs(config): (typo) Example 3 - custom vendor chunk using RegEx

* sakhisheikh
docs(config): (reworded) Example 3 - custom vendor chunk using RegEx

* docs(config): (Reword) Example 3 - custom vendor chunk using RegEx

* docs(config): (Reword) Example 3 - custom vendor chunk using RegEx

* chore(plugins) Remove space  (#2527)

* docs(config): Example 3 - custom vendor chunk using RegEx

* squashed everything after c81e77e

* docs(plugins) Add .mjs to the defaults (#2493)

This should be updated once webpack/webpack#7947 is released.

* chore(plugins) Minor SplitChunks Documentation Clean Up (#2252)

* Minor Documentation Clean Up

Originally, i was just trying to change defer => differ, but I ended up doing a bit more editing.

* Lower the case

* fix(api) Clarify module section (#2529)

Change wording from "bind an extension" to "bind a file extension" in order to distinguish from a webpack extension.

_describe your changes..._

- [ ] Read and sign the [CLA][1]. PRs that haven't signed it won't be accepted.
- [ ] Make sure your PR complies with the [writer's guide][2].
- [ ] Review the diff carefully as sometimes this can reveal issues.
- __Remove these instructions from your PR as they are for your eyes only.__


[1]: https://cla.js.foundation/webpack/webpack.js.org
[2]: https://webpack.js.org/writers-guide/

* docs(plugins): Update links in htmlwebpackplugin (#2530)

* docs(plugins) Fix reuseExistingChunk title nesting (#2526)

* docs(plugins) scp reuseExistingChunk title  nesting fix

* docs(plugins) scp reuseExistingChunk title notation

* docs(guides) Fix typo (#2537)

* chore(guides) Import needs to be highlighted with '+' mark (#2536)

import webpack needs to be highlighted since we are adding webpack.HashedModuleIdsPlugin()

* docs(config) Optimization moduleIds option (#2543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants