Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed link to output property #2489

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Fixed link to output property #2489

merged 3 commits into from
Sep 6, 2018

Conversation

m4jing
Copy link
Contributor

@m4jing m4jing commented Sep 5, 2018

The original link (/concepts/output) leads to an empty page.

@montogeek
Copy link
Member

It loads for me: https://webpack.js.org/concepts/output/
image

@byzyk
Copy link
Member

byzyk commented Sep 6, 2018

Might be a browser related bug? 🤔

@m4jing
Copy link
Contributor Author

m4jing commented Sep 6, 2018

There maybe other issue...
I encountered this issue in testing locally: http://localhost:3000/concepts/output/

Here is the details:
screen shot 2018-09-06 at 19 17 00

(1) If I click the nav-button in the side menu, it's OK:
screen shot 2018-09-06 at 19 22 08

(2) If I click the text anchor [our guide](/concepts/output), it'll results in an empty page:
screen shot 2018-09-06 at 19 22 32

My browser is:

Chrome, Version 68.0.3440.106 (Official Build) (64-bit)
Mac OSX 10.13.6

And I checked the online site, https://webpack.js.org/concepts/output/ goes well.

Strange though... 🤔

@montogeek
Copy link
Member

montogeek commented Sep 6, 2018

If you check the href attribute it is different:
"our guide" is /concepts/output
"Output" (navbar) is /concepts/output/.

I guess that webpack-dev-server doesn't handle it, but when running in a server it works just fine.

Can you try adding that / at the end and test locally?

@m4jing
Copy link
Contributor Author

m4jing commented Sep 6, 2018

@montogeek
Wow! You're a genius.
Yes, that's the problem.

I've checked that if I added the trailing /, it goes well.
Links without the trailing / all lead to the empty page when rendered locally.

@montogeek
Copy link
Member

montogeek commented Sep 6, 2018

Please push that change

@montogeek montogeek merged commit aba7ebe into webpack:master Sep 6, 2018
@montogeek
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants