Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config): Replace UglifyJSPlugin references with TerserPlugin #2522

Merged
merged 2 commits into from
Sep 18, 2018
Merged

docs(config): Replace UglifyJSPlugin references with TerserPlugin #2522

merged 2 commits into from
Sep 18, 2018

Conversation

edmorley
Copy link
Contributor

@edmorley edmorley commented Sep 16, 2018

Since as of webpack 5, the default options.minimizer is now terser-webpack-plugin:
webpack/webpack#8036

I've also:

  • updated the custom minimizer example to include all of the default options, to reduce the chance people forget to enable them.
  • removed the optimize/UglifyJsPlugin reference, since it's no longer included in the webpack repository.
  • removed the "Here are a few more popular ones" mention, since it's not accurate (they aren't more popular).
  • removed manual plugin configuration from configuration-languages.md since the defaults for minimizer make it unnecessary.

Fixes #2520.

Since the default `options.minimizer` is now `terser-webpack-plugin`:
webpack/webpack#8036

I've also:
* updated the custom `minimizer` example to include all of the default
  options, to reduce the chance people forget to enable them.
* removed the `optimize/UglifyJsPlugin` reference, since it's no
  longer included in the webpack repository.
* removed the "Here are a few more popular ones" mention, since it's
  not accurate (they aren't more popular).
* removed manual plugin configuration from `configuration-languages.md`
  since the defaults for `minimizer` make it unnecessary.

Fixes #2520.
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small q

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@montogeek montogeek merged commit 83fb9b2 into webpack:next Sep 18, 2018
@montogeek
Copy link
Member

Thanks!

@edmorley edmorley deleted the terser-webpack-plugin branch September 18, 2018 10:29
@edmorley
Copy link
Contributor Author

Thank you for the reviews/merge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants