-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(config): Replace UglifyJSPlugin references with TerserPlugin #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the default `options.minimizer` is now `terser-webpack-plugin`: webpack/webpack#8036 I've also: * updated the custom `minimizer` example to include all of the default options, to reduce the chance people forget to enable them. * removed the `optimize/UglifyJsPlugin` reference, since it's no longer included in the webpack repository. * removed the "Here are a few more popular ones" mention, since it's not accurate (they aren't more popular). * removed manual plugin configuration from `configuration-languages.md` since the defaults for `minimizer` make it unnecessary. Fixes #2520.
EugeneHlushko
requested changes
Sep 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small q
EugeneHlushko
approved these changes
Sep 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
byzyk
reviewed
Sep 17, 2018
Thanks! |
Thank you for the reviews/merge :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since as of webpack 5, the default
options.minimizer
is nowterser-webpack-plugin
:webpack/webpack#8036
I've also:
minimizer
example to include all of the default options, to reduce the chance people forget to enable them.optimize/UglifyJsPlugin
reference, since it's no longer included in the webpack repository.configuration-languages.md
since the defaults forminimizer
make it unnecessary.Fixes #2520.