Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(plugins) move code example related warning to the code blocks #2638

Merged
merged 2 commits into from Nov 12, 2018

Conversation

EugeneHlushko
Copy link
Member

Move related code example warning to the code block itself in order to avoid confusion, many come to see how to use NODE_ENV so the previous block location was too deep without giving appropriate warning immediately.

@montogeek montogeek merged commit 29efde5 into master Nov 12, 2018
@montogeek montogeek deleted the plugins/define-plugin-warning branch November 12, 2018 20:34
@montogeek
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants