fix(plugins): Fix SplitChunksPlugin cacheGroup priority option #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`priority` option should belong to `cacheGroups.{cacheGroup}`, should not belong to `cacheGroups`
|
Preview is ready Built with commit 8dd65a1 https://deploy-preview-3060--webpackjsorg-netlify.netlify.com |
EugeneHlushko
approved these changes
May 24, 2019
|
@butsalt please sign CLA |
|
@EugeneHlushko Weird, I have signed CLA yesterday. The link is https://cla.js.foundation/webpack/webpack.js.org, right? Maybe it references to this. |
|
Or please try 'Recheck PRS'. |
|
IIRC there was one more issue earlier, can we try reopening this PR? |
|
So what else I can do? :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
priorityoption should belong tocacheGroups.{cacheGroup}, should not belong tocacheGroups