Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(configuration): add new cache options #4807

Merged
merged 6 commits into from Apr 10, 2021
Merged

docs(configuration): add new cache options #4807

merged 6 commits into from Apr 10, 2021

Conversation

jamesgeorge007
Copy link
Member

closes #4800

@vercel
Copy link

vercel bot commented Apr 5, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/5mWCWQ7dT1npL1cJXKUYcgZ8tkdS
✅ Preview: https://webpack-js-org-git-fork-jamesgeorge007-docs-configuratio-9077c2.vercel.app

@jamesgeorge007 jamesgeorge007 changed the title docs(configuration): add new properties for cache docs(configuration): add new cache options Apr 5, 2021
@jamesgeorge007 jamesgeorge007 marked this pull request as ready for review April 5, 2021 07:46
chenxsan
chenxsan reviewed Apr 9, 2021
View reviewed changes
src/content/configuration/other-options.md Outdated Show resolved Hide resolved
src/content/configuration/other-options.md Outdated Show resolved Hide resolved
src/content/configuration/other-options.md Outdated Show resolved Hide resolved
src/content/configuration/other-options.md Outdated Show resolved Hide resolved
src/content/configuration/other-options.md Outdated Show resolved Hide resolved
src/content/configuration/other-options.md Outdated Show resolved Hide resolved
src/content/configuration/other-options.md Outdated Show resolved Hide resolved
src/content/configuration/other-options.md Outdated Show resolved Hide resolved
src/content/configuration/other-options.md Outdated Show resolved Hide resolved
src/content/configuration/other-options.md Outdated Show resolved Hide resolved
chenxsan
chenxsan previously approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! One last thing, <Badge /> would only work in .mdx, but I can make the change later if you don't have time.

@jamesgeorge007
Copy link
Member Author

Good catch, I'll handle it.

@chenxsan chenxsan merged commit 1131315 into webpack:master Apr 10, 2021
@jamesgeorge007 jamesgeorge007 deleted the docs/configuration branch April 10, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxsan chenxsan chenxsan approved these changes

Assignees
No one assigned
Labels
Configuration
Projects
None yet
Milestone
No milestone
2 participants
@jamesgeorge007 @chenxsan