Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct URL encoded value for space #5155

Closed
wants to merge 1 commit into from

Conversation

sudo-barun
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Jul 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/4Cm1ZRCf4AXAum5uv4vsjTfVaUHE
✅ Preview: https://webpack-js-org-git-fork-sudo-barun-patch-1-webpack-docs.vercel.app

@chenxsan
Copy link
Member

chenxsan commented Jul 6, 2021

@chenxsan chenxsan added the Guides label Jul 6, 2021
@sudo-barun
Copy link
Author

@sudo-barun Could you sign cla here https://cla.js.foundation/webpack/webpack.js.org?pullRequest=5155?

@chenxsan Why is that necessary?

@chenxsan
Copy link
Member

chenxsan commented Jul 6, 2021

As far as I know, it's how the webpack repository deals with the intellectual property. You might want to check webpack/webpack#13576 (comment) for details from the author.

@sudo-barun
Copy link
Author

@chenxsan Then, create your own this pull request with this change. I am not going into the hassle just for this small change.

@chenxsan
Copy link
Member

chenxsan commented Jul 6, 2021

Superseded by #5156. @sudo-barun Thanks for heads-up.

@chenxsan chenxsan closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants