-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ESM #5396
Use ESM #5396
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/7kRWdfYR4PdoYAomCfKQhCyZs4uV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
The whole remark ecosystem has migrated to ESM now. Packages like
node-fetch
did it as well. Thus I think we should commence the migration, otherwise we might get stuck in the CommonJS world with a lot of outdated packages.some problems
remark-gfm 2.0.0
is not compatible with@mdx-js/loader
. While replacing@mdx-js/loader
withxdm
would fix the problem, migrating to ESM-onlyxdm
is much difficult than I expected when we have server side rendering enabled, so I might do it in another pull request if I can figure out how.