Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ESM #5396

Merged
merged 38 commits into from
Sep 20, 2021
Merged

Use ESM #5396

merged 38 commits into from
Sep 20, 2021

Conversation

chenxsan
Copy link
Member

@chenxsan chenxsan commented Sep 1, 2021

The whole remark ecosystem has migrated to ESM now. Packages like node-fetch did it as well. Thus I think we should commence the migration, otherwise we might get stuck in the CommonJS world with a lot of outdated packages.

some problems

  1. remark-gfm 2.0.0 is not compatible with @mdx-js/loader. While replacing @mdx-js/loader with xdm would fix the problem, migrating to ESM-only xdm is much difficult than I expected when we have server side rendering enabled, so I might do it in another pull request if I can figure out how.

@vercel
Copy link

vercel bot commented Sep 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/7kRWdfYR4PdoYAomCfKQhCyZs4uV
✅ Preview: https://webpack-js-org-git-fork-chenxsan-feature-use-esm-webpack-docs.vercel.app

package.json Outdated Show resolved Hide resolved
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chenxsan chenxsan merged commit cd9568f into webpack:master Sep 20, 2021
@chenxsan chenxsan deleted the feature/use-esm branch September 20, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants