CI: cancel previous runs for pull requests #6437
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit 9faeca2.
| on: | ||
| workflow_run: | ||
| workflows: ["Ensure PR"] | ||
| types: | ||
| - requested |
There was a problem hiding this comment.
| on: | |
| workflow_run: | |
| workflows: ["Ensure PR"] | |
| types: | |
| - requested | |
| on: | |
| pull_request: |
There was a problem hiding this comment.
Nah, it won't run against those pull requests from forks https://github.com/styfle/cancel-workflow-action#advanced-pull-requests-from-forks. E.g, I'm submitting this pull request from my forked repository.
There was a problem hiding this comment.
Try this, we have a similar setup in webpack-contrib and it runs on PR from forks.
There was a problem hiding this comment.
Thanks. Any reason to avoid workflow_run? Seems fine to me according to the documentation.
There was a problem hiding this comment.
Is it running with workflow_run? I don't see it running in this PR.
There was a problem hiding this comment.
Maybe we can only test it after getting it merged, not in this one.
There was a problem hiding this comment.
I'm good with it if it works 👍
There was a problem hiding this comment.
I'll test it once merged.
| steps: | ||
| - uses: styfle/cancel-workflow-action | ||
| with: | ||
| workflow_id: ${{ github.event.workflow.id }} |
There was a problem hiding this comment.
| workflow_id: ${{ github.event.workflow.id }} | |
| workflow_id: testing.yml | |
| access_token: ${{ github.token }} |
No description provided.