New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple Production section #650
Add simple Production section #650
Conversation
|
||
### Production | ||
|
||
Minimal steps in order to get rid out of the HMR on production. As webpack sets `NODE_ENV` for working files only, we need to specify it before webpack for production is onvoked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/s/onvoked/invoked
|
||
### Production | ||
|
||
Minimal steps in order to get rid out of the HMR on production. As webpack sets `NODE_ENV` for working files only, we need to specify it before webpack for production is onvoked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"to get rid out of the" -> "to get rid of"
deefd28
to
61b5954
Compare
…logs after production compilation. It contains plain recommendations for production bundling. Fix webpack#649 Fix typos after review.
03b55e6
to
0706631
Compare
Have fixed everything. The |
I wonder if it would make sense to link to the production article at the end and merge this information there. That would keep this on topic. |
Up to you guys, but in my opinion if I want precisely HMR for production, I would look for solution in HMR article. |
Ah, I understand now. I handle the situation quite differently myself. I go with an inverse approach and add HMR to the development configuration avoiding the problem entirely. But better wait for further comments. |
@bebraw I also do it like you. Resetting the |
Yeah, let's skip this one. That said, inverse approach or hinting about it would work. |
Production section explains how to get rid out of HMR error and warn logs after production compilation.
It contains plain recommendations for production bundling.
Fix #649