Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: splitChunks maxSize/minSize/maxRequest priority #7123

Merged
merged 1 commit into from
Feb 11, 2024
Merged

fix: splitChunks maxSize/minSize/maxRequest priority #7123

merged 1 commit into from
Feb 11, 2024

Conversation

hai-x
Copy link
Contributor

@hai-x hai-x commented Jan 27, 2024 •
edited by snitin315
Loading

Fix webpack/webpack#17970
Fix #7118

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 27, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: haijie-x / name: Hai (ce61725)

@vercel Vercel
Copy link

vercel bot commented Jan 27, 2024

@haijie-x is attempting to deploy a commit to the Webpack Docs Team on Vercel.

A member of the Team first needs to authorize it.

@hai-x
Copy link
Contributor Author

hai-x commented Jan 27, 2024 •
edited
Loading

https://v4.webpack.js.org/plugins/split-chunks-plugin/#splitchunksmaxsize
I found that v4 website also has related error. Do I need to deal with it, or will this PR automatically modify v4 website?

@vercel Vercel
Copy link

vercel bot commented Jan 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webpack-js-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2024 11:25am

snitin315
snitin315 approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@snitin315 snitin315 merged commit 04c0df1 into webpack:main Feb 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

splitChunks maxSize/minSize/maxRequest priority
2 participants
@hai-x @snitin315