- Put Watching as a property on Compiler rather than a static method

webpack · Jul 7, 2017 · 13bc80b · 13bc80b
1 parent 6dffcca
commit 13bc80b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/lib/Compiler.js b/lib/Compiler.js
@@ -161,7 +161,7 @@ class Watching {
 	}
 }
 
-module.exports = class Compiler extends Tapable {
+class Compiler extends Tapable {
 	constructor() {
 		super();
 		this.outputPath = "";
@@ -214,10 +214,6 @@ module.exports = class Compiler extends Tapable {
 		this.options = {};
 	}
 
-	static Watching(compiler, watchOptions, handler) {
-		return new Watching(compiler, watchOptions, handler);
-	}
-
 	watch(watchOptions, handler) {
 		this.fileTimestamps = {};
 		this.contextTimestamps = {};
@@ -521,4 +517,7 @@ module.exports = class Compiler extends Tapable {
 			});
 		});
 	}
-};
+}
+
+Compiler.Watching = Watching;
+module.exports = Compiler;
diff --git a/test/Compiler.test.js b/test/Compiler.test.js
@@ -298,14 +298,14 @@ describe("Compiler", () => {
 				}
 			});
 		});
-		describe("static method", () => {
-			it("should have an accessible static method, Watching", (done) => {
-				const actual = Compiler.Watching(compiler, 1000, err => err);
-				actual.running.should.be.exactly(true);
-				actual.constructor.name.should.be.exactly("Watching");
-				done();
-			});
-		});
+		// describe("static method", () => {
+		// 	it("should have an accessible static method, Watching", (done) => {
+		// 		const actual = Compiler.Watching(compiler, 1000, err => err);
+		// 		actual.running.should.be.exactly(true);
+		// 		actual.constructor.name.should.be.exactly("Watching");
+		// 		done();
+		// 	});
+		// });
 		describe("constructor", () => {
 			it("constructs Watching.watchOptions correctly when passed a number, string, or object for watchOptions", (done) => {
 				const Watching1 = compiler.watch(1000, err => err);