better error message for missing internal names

webpack · Jun 20, 2017 · 245dcc3 · 245dcc3
1 parent bf4ec9c
commit 245dcc3
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/optimize/ConcatenatedModule.js b/lib/optimize/ConcatenatedModule.js
@@ -24,7 +24,10 @@ function getFinalName(info, exportName, moduleToInfoMap, requestShortener) {
 	if(directExport) {
 		if(exportName === true)
 			info.needNamespaceObject = true;
-		return info.internalNames.get(directExport);
+		const name = info.internalNames.get(directExport);
+		if(!name)
+			throw new Error(`The export "${directExport}" in "${info.module.readableIdentifier(requestShortener)}" has no internal name`);
+		return name;
 	}
 	const reexport = info.reexportMap.get(exportName);
 	if(reexport) {
@@ -380,8 +383,6 @@ class ConcatenatedModule extends Module {
 						exportName = referencedModule.module.providedExports[exportIdx];
 					}
 					const finalName = getFinalName(referencedModule, exportName, moduleToInfoMap, requestShortener);
-					if(!finalName)
-						throw new Error(`Cannot map to variable name in module ${info.module.resource} (export '${exportName}')`);
 					const r = reference.identifier.range;
 					const source = info.source;
 					source.replace(r[0], r[1] - 1, finalName);