Merge pull request #16685 from weareoutman/main

Fix a bug in Module Federation where a package self-references itself in a shared module
webpack · Apr 5, 2023 · 2703c1b · 2703c1b
2 parents 765cbff + be8b1a1
commit 2703c1b
Show file tree

Hide file tree

Showing 9 changed files with 70 additions and 0 deletions.
diff --git a/lib/sharing/ConsumeSharedPlugin.js b/lib/sharing/ConsumeSharedPlugin.js
@@ -224,6 +224,10 @@ class ConsumeSharedPlugin {
 										);
 										return resolve();
 									}
+									if (data.name === packageName) {
+										// Package self-referencing
+										return resolve();
+									}
 									const requiredVersion = getRequiredVersionFromDescriptionFile(
 										data,
 										packageName

diff --git a/test/configCases/sharing/consume-self-reference/index.js b/test/configCases/sharing/consume-self-reference/index.js
@@ -0,0 +1,4 @@
+it("should be able to consume package self referencing", async () => {
+	const result = await import("my-middleware");
+	expect(result.m()).toBe("ABA");
+});
diff --git a/test/configCases/sharing/consume-self-reference/node_modules/my-middleware/index.js b/test/configCases/sharing/consume-self-reference/node_modules/my-middleware/index.js
diff --git a/test/configCases/sharing/consume-self-reference/node_modules/my-middleware/package.json b/test/configCases/sharing/consume-self-reference/node_modules/my-middleware/package.json
diff --git a/test/configCases/sharing/consume-self-reference/node_modules/my-module/a.js b/test/configCases/sharing/consume-self-reference/node_modules/my-module/a.js
diff --git a/test/configCases/sharing/consume-self-reference/node_modules/my-module/b.js b/test/configCases/sharing/consume-self-reference/node_modules/my-module/b.js
diff --git a/test/configCases/sharing/consume-self-reference/node_modules/my-module/package.json b/test/configCases/sharing/consume-self-reference/node_modules/my-module/package.json
diff --git a/test/configCases/sharing/consume-self-reference/package.json b/test/configCases/sharing/consume-self-reference/package.json
@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "my-middleware": "^2.3.0"
+  }
+}
diff --git a/test/configCases/sharing/consume-self-reference/webpack.config.js b/test/configCases/sharing/consume-self-reference/webpack.config.js
@@ -0,0 +1,26 @@
+// eslint-disable-next-line node/no-unpublished-require
+const { SharePlugin } = require("../../../../").sharing;
+
+/** @type {import("../../../../").Configuration} */
+module.exports = {
+	plugins: [
+		new SharePlugin({
+			shared: {
+				"my-middleware": {
+					singleton: true
+					// import: false
+				},
+				"my-module/a": {
+					singleton: true,
+					version: "1.2.3"
+					// import: false
+				},
+				"my-module/b": {
+					singleton: true,
+					version: "1.2.3"
+					// import: false
+				}
+			}
+		})
+	]
+};