Merge pull request #5160 from asmundg/fix-amd-deprecation-warning

Replace deprecated Chunk.modules usage
webpack · Jul 1, 2017 · 53944e8 · 53944e8
2 parents 6199454 + 0c4ab4a
commit 53944e8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/AmdMainTemplatePlugin.js b/lib/AmdMainTemplatePlugin.js
@@ -17,7 +17,7 @@ class AmdMainTemplatePlugin {
 		const mainTemplate = compilation.mainTemplate;
 
 		compilation.templatesPlugin("render-with-entry", (source, chunk, hash) => {
-			const externals = chunk.modules.filter((m) => m.external);
+			const externals = chunk.getModules().filter((m) => m.external);
 			const externalsDepsArray = JSON.stringify(externals.map((m) =>
 				typeof m.request === "object" ? m.request.amd : m.request
 			));

diff --git a/test/AmdMainTemplatePlugin.test.js b/test/AmdMainTemplatePlugin.test.js
@@ -67,7 +67,7 @@ describe("AmdMainTemplatePlugin", () => {
 				describe("with name", () => {
 					beforeEach(() => {
 						env.chunk = {
-							modules: env.modulesListWithExternals
+							getModules: () => env.modulesListWithExternals
 						};
 						env.eventBinding = setupPluginAndGetEventBinding("foo");
 					});
@@ -82,7 +82,7 @@ describe("AmdMainTemplatePlugin", () => {
 				describe("with external dependencies", () => {
 					beforeEach(() => {
 						env.chunk = {
-							modules: env.modulesListWithExternals
+							getModules: () => env.modulesListWithExternals
 						};
 						env.eventBinding = setupPluginAndGetEventBinding();
 					});
@@ -101,7 +101,7 @@ describe("AmdMainTemplatePlugin", () => {
 						};
 						const noExternals = env.modulesListWithExternals.map((module) => Object.assign(module, externalFlag));
 						env.chunk = {
-							modules: noExternals
+							getModules: () => env.modulesListWithExternals
 						};
 						env.eventBinding = setupPluginAndGetEventBinding();
 					});