Merge pull request #14434 from buzuosheng/fix-chunkId

replace chunkIds[i] with chunkId in JsonpChunkLoadingRuntimeModule
webpack · Jan 10, 2022 · 98887e4 · 98887e4
2 parents f1833b1 + dbf8b35
commit 98887e4
Show file tree

Hide file tree

Showing 3 changed files with 188 additions and 188 deletions.
diff --git a/lib/web/JsonpChunkLoadingRuntimeModule.js b/lib/web/JsonpChunkLoadingRuntimeModule.js
@@ -419,7 +419,7 @@ class JsonpChunkLoadingRuntimeModule extends RuntimeModule {
 									`if(${RuntimeGlobals.hasOwnProperty}(installedChunks, chunkId) && installedChunks[chunkId]) {`,
 									Template.indent("installedChunks[chunkId][0]();"),
 									"}",
-									"installedChunks[chunkIds[i]] = 0;"
+									"installedChunks[chunkId] = 0;"
 								]),
 								"}",
 								withOnChunkLoad

diff --git a/test/Stats.test.js b/test/Stats.test.js
@@ -175,10 +175,10 @@ describe("Stats", () => {
 			      "assets": Array [
 			        Object {
 			          "name": "entryB.js",
-			          "size": 2964,
+			          "size": 2961,
 			        },
 			      ],
-			      "assetsSize": 2964,
+			      "assetsSize": 2961,
 			      "auxiliaryAssets": undefined,
 			      "auxiliaryAssetsSize": 0,
 			      "childAssets": undefined,
@@ -223,10 +223,10 @@ describe("Stats", () => {
 			      "info": Object {
 			        "javascriptModule": false,
 			        "minimized": true,
-			        "size": 2964,
+			        "size": 2961,
 			      },
 			      "name": "entryB.js",
-			      "size": 2964,
+			      "size": 2961,
 			      "type": "asset",
 			    },
 			    Object {