Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of compatibility issues with Webpack #2101

Closed
dukedougal opened this issue Feb 25, 2016 · 14 comments
Closed

Lots of compatibility issues with Webpack #2101

dukedougal opened this issue Feb 25, 2016 · 14 comments
Labels

Comments

@dukedougal
Copy link

Having just spent an entire day tracking down problems that ended up being issues with Webpack, I'm starting to wonder if there is a general compatibility problem with Webpack and if maybe the onus isn't on Webpack to be more compatible?

It's getting a little tedious fighting through issues and I'm now starting to assume when there is a problem thinking "hmmm.... probably Webpack.".

Here's some of the action:

Azure/autorest#734
kriszyp/json-schema#59
AzureAD/azure-activedirectory-library-for-nodejs#100
aws/aws-sdk-js#603
#2076
TritonDataCenter/node-jsprim#13

Each of these issues represents many hours and days diagnosing and tracking down problems and unfortunately not writing any features or functions for my application.

Sorry to be blunt about it because I know everyone is working hard, it's just that the pattern is starting to become clear....

@dukedougal
Copy link
Author

The outcome is still that Azure is broken with Webpack.

Azure say its not their problem, Webpack seem to think everyone else needs to make their packages compatible with it instead of the other way around, and the guy behind the json-schema package appears to have no interest in making his package to work with webpack.

It's a mexican standoff in which no-one wants to do what it takes to make their software work with each other.

Azure/autorest#734
kriszyp/json-schema#59

What can be done?

@agundermann
Copy link

What are you trying to do exactly? These all look like modules that were not designed for the browser.

If you use webpack to transpile and bundle your node js code, you might want to look into excluding node_modules from your bundle. This way, your bundle would include require(..) calls to your dependencies.

deepakjois added a commit to MOOCFetcher/moocfetcher-api that referenced this issue May 17, 2016
Read here for details:
* kriszyp/json-schema#59
* webpack/webpack#2101

Used a fix mentioned here:
* webpack/webpack#138

Works for now…
@TheLarkInn
Copy link
Member

@amarzavery what can we do @ webpack to remedy this? Dep change? @dukedougal can you please submit a new issue in regards to this and tie this issue I want to verify the following:

  • is this still an issue in latest webpack and auto rest
  • we have all the information needed (found in our updated github issue template) this can assist us in fixing this issue.

@bebraw
Copy link
Contributor

bebraw commented Aug 8, 2016

Closing due to lack of answer. Feel free to open separate issues or use Stack Overflow for support level questions.

@bebraw bebraw closed this as completed Aug 8, 2016
@ForsakenHarmony
Copy link

That doesn't make any sense

@ForsakenHarmony
Copy link

seriously, this is webpack's fault and you just close this

@TheLarkInn
Copy link
Member

We stayed pretty clearly why we closed it. We are willing to help if we are provided more information, etc.

@ForsakenHarmony
Copy link

well, what about the issues linked here?
the closed one for json-schema still doesn't fix it for me

@ForsakenHarmony
Copy link

I have no way to work on my current website because of this, not even noparse fixed it

@bebraw
Copy link
Contributor

bebraw commented Sep 11, 2016

@ForsakenHarmony Can you open a separate issue about that? Easier to digest, get fixed. 👍

@ForsakenHarmony
Copy link

well, it's probably a problem with meteor-webpack, should I still do it?

@bebraw
Copy link
Contributor

bebraw commented Sep 11, 2016

@ForsakenHarmony If it's an upstream issue, start with meteor-webpack and see what they have to say. The challenge is in finding the right place to fix.

@ForsakenHarmony
Copy link

ForsakenHarmony commented Sep 11, 2016

 C:\Users\ArmyOfAnarchists\AppData\Local\.meteor\packages\meteor-tool\1.4.1_1\mt-os.windows.x86_32\dev_bundle\server-lib\node_modules\fibers\future.js:280
                                             throw(ex);
                                             ^

 Error: define cannot be used indirect
     at Object.module.exports [as define] (meteor://�app/webpack:///(webpack)/buildin/amd-define.js:1:1)
     at Object.module.exports (meteor://�app/webpack:///~/json-schema/lib/validate.js:20:1)
     at __webpack_require__ (meteor://�app/webpack:/webpack/bootstrap e2ec11292acb4393fb1d:22:1)
     at Object.<anonymous> (meteor://�app/webpack:///~/jsprim/lib/jsprim.js:13:1)
     at __webpack_require__ (meteor://�app/webpack:/webpack/bootstrap e2ec11292acb4393fb1d:22:1)
     at Object.<anonymous> (meteor://�app/webpack:///~/http-signature/lib/signer.js:11:1)
     at __webpack_require__ (meteor://�app/webpack:/webpack/bootstrap e2ec11292acb4393fb1d:22:1)
     at Object.<anonymous> (meteor://�app/webpack:///~/http-signature/lib/index.js:7:1)
     at __webpack_require__ (meteor://�app/webpack:/webpack/bootstrap e2ec11292acb4393fb1d:22:1)
     at Object.<anonymous> (meteor://�app/webpack:///~/request/request.js:16:1)

I don't quite understand the error, and have no way of tracing it, because the only file I know of is amd-define.js, which seemingly exports define, but instantly throws with anything using it

https://github.com/kriszyp/json-schema/blob/master/lib/validate.js

the file checks for define, and uses it, if it exists

@ForsakenHarmony
Copy link

ForsakenHarmony commented Sep 11, 2016

oh, wait, I'm sorry, it was 100% my fault, json-schema was updated, but the update wasn't released

we'll, not my fault, the package author's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants