New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UglifyJS errors don't bail the build with --bail #2390
Comments
Can you provide a test case so this can be debugged? |
@bebraw Check out at https://github.com/pdillon/webpack-bail-example. Ran into this issue where the babel loader was pulling in files outside of the include path, bypassing transpilation, and uglify throws an error. |
@pdillon Thanks. I added this to webpack 2 work. Given there's a test case, it should be easier to figure out the root cause. |
@bebraw would it make sense for bail to map to the NoErrorsPlugin, and for the plugin to pass an error to the callback if compilation.errors > 0? |
@pdillon I'm not sure. I think we'll have to wait for Tobias to check this out to get the behavior right. |
Is this not going to be fixed in webpack 1.13.x? |
Here is another minimal example. Webpack 2 does not bail when babel finds a syntax error. |
I've created a workaround that will detect UglifyJs errors and exit the process with a non-zero status code:
This works for me and outputs the same message webpack would otherwise output. |
This issue had no activity for at least half a year. It's subject to automatic issue closing if there is no activity in the next 15 days. |
Issue was closed because of inactivity. If you think this is still a valid issue, please file a new issue with additional information. |
webpack --bail:
The text was updated successfully, but these errors were encountered: