Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Es6 refactor in /lib folder #4854

Merged
merged 3 commits into from Jun 21, 2017
Merged

Es6 refactor in /lib folder #4854

merged 3 commits into from Jun 21, 2017

Conversation

Orlandster
Copy link
Contributor

What kind of change does this PR introduce?
Es6 refactor in /lib folder

Did you add tests for your changes?
No

If relevant, link to documentation update:
N/A

Summary
The Refactoring makes the code more consistent to the ES6 standards. issue #4099

Does this PR introduce a breaking change?
No

Other information
Thanks for the review.

@@ -3,49 +3,52 @@
Author Tobias Koppers @sokra
*/
/*globals hotAddUpdateChunk parentHotUpdateCallback document XMLHttpRequest $require$ $hotChunkFilename$ $hotMainFilename$ */
"use strict";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't refactor this file. It should be in low level js as it's embedded into the runtime code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I'm very new to the project and it helps me a lot! I will revert the commit and there's also another thing in the ContextModuleFactory.js I have to fix.

@Orlandster
Copy link
Contributor Author

@sokra Sorry, currently I'm struggling with the CI build error caused by ContextModuleFactory.js. It tells me "Block-scoped declarations (let, const, function, class) not yet supported outside strict mode". Do you have any idea why this happens? It's also failing without all the "const", "let" and "=>" . Seems to be something with the class declaration.

@sokra
Copy link
Member

sokra commented May 22, 2017

It tells me "Block-scoped declarations (let, const, function, class) not yet supported outside strict mode".

Don't touch the lib/JsonpMainTemplate.runtime.js file.

@webpack-bot
Copy link
Contributor

@Orlandster98 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra closed this Jun 14, 2017
@sokra sokra reopened this Jun 14, 2017
@sokra sokra merged commit c12a001 into webpack:master Jun 21, 2017
@sokra
Copy link
Member

sokra commented Jun 21, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants