New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Es6 refactor in /lib folder #4854
Conversation
lib/JsonpMainTemplate.runtime.js
Outdated
@@ -3,49 +3,52 @@ | |||
Author Tobias Koppers @sokra | |||
*/ | |||
/*globals hotAddUpdateChunk parentHotUpdateCallback document XMLHttpRequest $require$ $hotChunkFilename$ $hotMainFilename$ */ | |||
"use strict"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't refactor this file. It should be in low level js as it's embedded into the runtime code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. I'm very new to the project and it helps me a lot! I will revert the commit and there's also another thing in the ContextModuleFactory.js
I have to fix.
This reverts commit 0ab8cf9.
@sokra Sorry, currently I'm struggling with the CI build error caused by |
Don't touch the |
@Orlandster98 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Thanks |
What kind of change does this PR introduce?
Es6 refactor in /lib folder
Did you add tests for your changes?
No
If relevant, link to documentation update:
N/A
Summary
The Refactoring makes the code more consistent to the ES6 standards. issue #4099
Does this PR introduce a breaking change?
No
Other information
Thanks for the review.