New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES6 Refactor #4099
Comments
It's probably better to handle it per project. There's simply so much code the issue would become huge. |
It'd be huge, but there would be less of a chance to miss things. |
I mean, thats a lot of stuff I do agree though it would be good for people to see what remains on the list etc. But THATS ALOT OF STUFF to put in an issue 😂. I cant spend the time myself to document it all, but I'll mark this for contribs to see. |
A lot of refactors |
Hey!! We have been sorting out some CI stuff. This is my number one priority at the moment to jump back in and review and merge these. I appreciate your patience. |
Hey @TheLarkInn I'll take some of these on. |
@TheLarkInn @bebraw do we have a list of what is remaining to refactor? Just want to make sure no one picks up refactoring something that is already in PR. |
@tarang9211 I don't think there's an official list. I agree that makes it a little tough to coordinate PR work. Maybe it's better to help with reviews instead? |
@bebraw hmm, that's one way to help, sure. What exactly should I be looking for when I review? |
@tarang9211 I don't think we have official guidelines for reviews yet. I would look into the code very cafefully to make sure the port is complete. It's easy to miss some subtle behavior or improvement. Then comment at a PR after the review. Thanks. 👍 @TheLarkInn Official PR review guidelines would be handy. |
Hi i am a new here and would love to help. Please let me know what files are left to refactor. Thanks |
@neelbommisetty I suggest looking at what PRs aren't already up. This issue may be easy to close using 5to6 codemods |
…ckhelpers Issue #4099: ES6 Refactor for depdendencies/DepBlockHelpers.js
This issue had no activity for at least half a year. It's subject to automatic issue closing if there is no activity in the next 15 days. |
Issue was closed because of inactivity. If you think this is still a valid issue, please file a new issue with additional information. |
Do you want to request a feature or report a bug?
Feature.
What is the current behavior?
Not all
webpack@2
things use ES6 syntax as appropriate.If the current behavior is a bug, please provide the steps to reproduce.
What is the expected behavior?
webpack@2
things should use ES6 as appropriate.If this is a feature request, what is motivation or use case for changing the behavior?
Consistent code base.
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
N/A
There's been a lot of refactoring but I didn't see an issue for it. Should there be an umbrella issue? Should it cover other Webpack projects (
css-loader
,loader-utils
, et cetera)?The text was updated successfully, but these errors were encountered: