Issue #4099: ES6 Refactor for depdendencies/DepBlockHelpers.js #5098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
requested changes
Jul 1, 2017
lib/dependencies/DepBlockHelpers.js
Outdated
| (outputOptions.pathinfo && depBlock.chunkName ? "/*! " + requestShortener.shorten(depBlock.chunkName) + " */" : "") + | ||
| asComment(depBlock.chunkReason) + ")"; | ||
| const chunk = chunks[0]; | ||
| return `__webpack_require__.e${asComment(name)}(${JSON.stringify(chunk.id)}${outputOptions.pathinfo && depBlock.chunkName ? "/*! " + requestShortener.shorten(depBlock.chunkName) + " */" : ""}${asComment(depBlock.chunkReason)})`; |
There was a problem hiding this comment.
Try to move parts of the expression into a separate variable to avoid that long lines
|
@KTruong888 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
sokra
reviewed
Jul 1, 2017
lib/dependencies/DepBlockHelpers.js
Outdated
| return "__webpack_require__.e(" + JSON.stringify(chunk.id) + ")"; | ||
| }).join(", ") + | ||
| "])"; | ||
| return `Promise.all${asComment(name)}(${pathAndChunkCheck ? "/*! " + shortenedChunkName + " */" : ""}[${chunks.map(chunk => "__webpack_require__.e(" + JSON.stringify(chunk.id) + ")").join(", ")}])`; |
sokra
approved these changes
Jul 1, 2017
|
Thanks |
This was referenced Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
ES6 refactor of dependencies/DepBlockHelpers.js
Did you add tests for your changes?
Tests already written.
Summary
ES6 refactor as per issue #4099.