We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the current behavior? Some libraries depend on an exported module to have __esModule === true for understanding the export is an es module.
__esModule === true
However, module concatenation doesn't work with this behavior that it doesn't have the __esModule property.
If the current behavior is a bug, please provide the steps to reproduce. see the repo: https://github.com/Bobgy/webpack-concat-esmodule-bug-reproduction
What is the expected behavior?
regardless of a module is concatenated or not, it should have module.exports.__esModule === true
module.exports.__esModule === true
Other relevant information: webpack version: 4.29.0 Node.js version: 8.12 Operating System: Ubuntu 18.04 Additional tools:
The text was updated successfully, but these errors were encountered:
I'm not fully sure if this behavior is intended or not. Just tested this and it seems the behavior is the same from webpack 4.0
Sorry, something went wrong.
Yep, seem to be a bug..
42007e8
Merge pull request #8667 from webpack/bugfix/esModule-flag
a0eab48
fixes #8666
Awesome, thank you for the quick fix!
No branches or pull requests
Bug report
What is the current behavior?
Some libraries depend on an exported module to have
__esModule === true
for understanding the export is an es module.However, module concatenation doesn't work with this behavior that it doesn't have the __esModule property.
If the current behavior is a bug, please provide the steps to reproduce.
see the repo: https://github.com/Bobgy/webpack-concat-esmodule-bug-reproduction
What is the expected behavior?
regardless of a module is concatenated or not, it should have
module.exports.__esModule === true
Other relevant information:
webpack version: 4.29.0
Node.js version: 8.12
Operating System: Ubuntu 18.04
Additional tools:
The text was updated successfully, but these errors were encountered: