feat(wasm): allow WebAssembly module filenames to use more path templates (e.g. [file], [base]) #10202
+264
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Comment on lines
13
to
18
| let found = false; | ||
| stats.assets.forEach((asset) => { | ||
| found = found || !!asset.name.match( | ||
| /^\w{20}\.\w{20}\.\w{16}\.wasm\.wat\.wat\.wasm$/ | ||
| ); | ||
| }); |
There was a problem hiding this comment.
const found = stats.assets.every((asset) => {
!!asset.name.match(
/^\w{20}\.\w{20}\.\w{16}\.wasm\.wat\.wat\.wasm$/
);
});What about this approach?
There was a problem hiding this comment.
@jamesgeorge007 Good idea, I did this with the slight change that it should be .some rather than .every (I'm looking for only one outputted file that matches this reg exp).
Comment on lines
13
to
18
| let found = false; | ||
| stats.assets.forEach((asset) => { | ||
| found = found || !!asset.name.match( | ||
| /^\w{20}\.\w{20}\.\w{16}\.wasm\.wat\.wat\.wasm$/ | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #9517 (I used this to dive into the webpack source a bit since this issue looked inactive)
The problem is that currently you can only use
[hash]to set a wasm output filename:More options would be useful, such as:
[base].wasm, etc.Changes were needed in
TemplatedPathPlugin.jsbecause the wasm path templates were not being set correctly. For example, in the output, I would get the path string:but, I wanted the output:
I adjusted the
TemplatedPathPluginso that it could be easier to handle the many templates that stem from thefilenameproperty (e.g.base,ext,file) in this situation.I added tests using configs that encompass many of the template cases:
webassemblyModuleFilename: "[fullhash].[hash].[hash:16].[base][ext].wasm"What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No, there should be no breaking changes.
What needs to be documented once your changes are merged?
wasm in general seems to not be documented well, so that in addition to the new path templates for
webassemblyModuleFilename.