Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of some hacks in declarations file for webpack-4 #10240

Merged
merged 5 commits into from Jan 15, 2020

Conversation

jeffin143
Copy link
Contributor

What kind of change does this PR introduce?
Backport #10050 to webpack-4

Fix - #10217
Did you add tests for your changes?
NA

Does this PR introduce a breaking change?
None

What needs to be documented once your changes are merged?
Nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

declarations.d.ts Show resolved Hide resolved
@webpack-bot
Copy link
Contributor

@jeffin143 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@jeffin143
Copy link
Contributor Author

@sokra , need help with error :

declarations/WebpackOptions.d.ts need to be updated

@sokra
Copy link
Member

sokra commented Jan 14, 2020

@sokra , need help with error :

declarations/WebpackOptions.d.ts need to be updated

run yarn special-lint-fix

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@jeffin143
Copy link
Contributor Author

@sokra should we still keep node-6 pipeline ?

@sokra sokra merged commit 5e9f083 into webpack:webpack-4 Jan 15, 2020
@sokra
Copy link
Member

sokra commented Jan 15, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants