fix: better handle absolute paths #10255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
requested changes
Jan 15, 2020
schemas/ajv.absolutePath.js
Outdated
| // \\\\ - Windows network absolute path | ||
| // \/ - Unix-like OS absolute path | ||
| const isCorrectAbsolutePath = | ||
| expected === /^(?:[A-Za-z]:(\\|\/)|\\\\|\/)/.test(data); |
There was a problem hiding this comment.
Suggested change
| expected === /^(?:[A-Za-z]:(\\|\/)|\\\\|\/)/.test(data); | |
| expected === /^(?:[A-Za-z]:\\|\\\\|\/)/.test(data); |
correct windows paths must use \ and not /.
There was a problem hiding this comment.
@sokra Windows supports c:/foo/bar https://nodejs.org/api/path.html#path_path_isabsolute_path
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@jeffin143 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
sokra
approved these changes
Jan 15, 2020
jamesgeorge007
approved these changes
Jan 15, 2020
|
Thasnk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix : #10247
Did you add tests for your changes?
NA
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
May be that webpack-4 can now handle Absolute network paths, Not sure