backport: do not evaluate constants in asm.js, fix IIFE mode detection #10294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
ngg
changed the title
sokra
approved these changes
Feb 10, 2020
webpack-bot
added
PR: reviewed-approved
PR: CI-not-ok
and removed
PR: unreviewed
PR: CI-ok
labels
sokra
approved these changes
Feb 11, 2020
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports PR #10288
fixes #10283
What kind of change does this PR introduce?
This PR basically disables the ConstPlugin in asm.js functions.
Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
It should not cause any compatibility problems.
What needs to be documented once your changes are merged?
Probably nothing.