Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump terser-webpack-plugin from 2.3.1 to 2.3.3 #10305

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps terser-webpack-plugin from 2.3.1 to 2.3.3.

Release notes

Sourced from terser-webpack-plugin's releases.

v2.3.3

2.3.3 (2020-01-28)

Bug Fixes

  • license files now have .txt suffix by default (#210) (de02f7b)
  • reduce memory usage (abfd950)

v2.3.2

2.3.2 (2020-01-09)

Bug Fixes

Changelog

Sourced from terser-webpack-plugin's changelog.

2.3.3 (2020-01-28)

Bug Fixes

  • license files now have .txt suffix by default (#210) (de02f7b)
  • reduce memory usage (abfd950)

2.3.2 (2020-01-09)

Bug Fixes

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jan 28, 2020
@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@alexander-akait
Copy link
Member

Reduce memory usage for big projects around 80-90%

@webpack-bot
Copy link
Contributor

The basic integration tests failed.

@dependabot-preview[bot] Please review the following output log for errors:

FAIL test/ConfigTestCases.test.js (41.051s)
  ● ConfigTestCases › plugins › terser-plugin › exported tests › should extract comments to separate file

    ENOENT: no such file or directory, open '/home/travis/build/webpack/webpack/test/js/config/plugins/terser-plugin/extract.js.LICENSE'

      28 | /*! runtime requirements: __webpack_require__ */
      29 | /*! ModuleConcatenation bailout: Module is not an ECMAScript module */
    > 30 | it("should contain no comments in out chunk",()=>{const t=o(/*! fs */747).readFileSync(__filename,"utf-8");expect(t).not.toMatch(/[^\"]comment should be stripped test\.1[^\"]/),expect(t).not.toMatch(/[^\"]comment should be stripped test\.2[^\"]/),expect(t).not.toMatch(/[^\"]comment should be stripped test\.3[^\"]/)}),it("should contain comments in vendors chunk",(function(){const t=o(/*! fs */747),e=o(/*! path */622),c=t.readFileSync(e.join(__dirname,"vendors.js"),"utf-8");expect(c).toMatch("comment should not be stripped vendors.1"),expect(c).toMatch("// comment should not be stripped vendors.2"),expect(c).toMatch(" * comment should not be stripped vendors.3")})),it("should extract comments to separate file",(function(){const t=o(/*! fs */747),e=o(/*! path */622),c=t.readFileSync(e.join(__dirname,"extract.js.LICENSE"),"utf-8");expect(c).toMatch("comment should be extracted extract-test.1"),expect(c).not.toMatch("comment should be stripped extract-test.2"),expect(c).toMatch("comment should be extracted extract-test.3"),expect(c).not.toMatch("comment should be stripped extract-test.4")})),it("should remove extracted comments and insert a banner",(function(){const t=o(/*! fs */747),e=o(/*! path */622),c=t.readFileSync(e.join(__dirname,"extract.js"),"utf-8");expect(c).not.toMatch("comment should be extracted extract-test.1"),expect(c).not.toMatch("comment should be stripped extract-test.2"),expect(c).not.toMatch("comment should be extracted extract-test.3"),expect(c).not.toMatch("comment should be stripped extract-test.4"),expect(c).toMatch("/*! For license information please see extract.js.LICENSE */")})),it("should pass mangle options",(function(){const t=o(/*! fs */747),e=o(/*! path */622),c=t.readFileSync(e.join(__dirname,"ie8.js"),"utf-8");expect(c).toMatch(/\.exports=function\((\w)\)\{return function\((\w)\)\{try\{\1\(\)\}catch\(\1\)\{\2\(\1\)\}\}\}/)})),it("should pass compress options",(function(){const t=o(/*! fs */747),e=o(/*! path */622),c=t.readFileSync(e.join(__dirname,"compress.js"),"utf-8");expect(c).toMatch(".exports=function(){console.log(4),console.log(6),console.log(4),console.log(7)}")})),Math.random()<0&&o(/*! ./test.js */393)})();
         |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            ^

      at test/js/config/plugins/terser-plugin/bundle0.js:30:780
      at Object.<anonymous> (test/helpers/createLazyTestEnv.js:12:13)
Show remaining errors
  ● ConfigTestCases › plugins › terser-plugin › exported tests › should remove extracted comments and insert a banner

    expect(received).toMatch(expected)

    Expected substring: "/*! For license information please see extract.js.LICENSE */"
    Received string:    "/*! For license information please see extract.js.LICENSE.txt */
    (()=>{var r={2:r=>{r.exports={}}},t={};!function e(o){if(t[o])return t[o].exports;var p=t[o]={exports:{}};return r[o](p,p.exports,e),p.exports}(2)})();"

      28 | /*! runtime requirements: __webpack_require__ */
      29 | /*! ModuleConcatenation bailout: Module is not an ECMAScript module */
    > 30 | it("should contain no comments in out chunk",()=>{const t=o(/*! fs */747).readFileSync(__filename,"utf-8");expect(t).not.toMatch(/[^\"]comment should be stripped test\.1[^\"]/),expect(t).not.toMatch(/[^\"]comment should be stripped test\.2[^\"]/),expect(t).not.toMatch(/[^\"]comment should be stripped test\.3[^\"]/)}),it("should contain comments in vendors chunk",(function(){const t=o(/*! fs */747),e=o(/*! path */622),c=t.readFileSync(e.join(__dirname,"vendors.js"),"utf-8");expect(c).toMatch("comment should not be stripped vendors.1"),expect(c).toMatch("// comment should not be stripped vendors.2"),expect(c).toMatch(" * comment should not be stripped vendors.3")})),it("should extract comments to separate file",(function(){const t=o(/*! fs */747),e=o(/*! path */622),c=t.readFileSync(e.join(__dirname,"extract.js.LICENSE"),"utf-8");expect(c).toMatch("comment should be extracted extract-test.1"),expect(c).not.toMatch("comment should be stripped extract-test.2"),expect(c).toMatch("comment should be extracted extract-test.3"),expect(c).not.toMatch("comment should be stripped extract-test.4")})),it("should remove extracted comments and insert a banner",(function(){const t=o(/*! fs */747),e=o(/*! path */622),c=t.readFileSync(e.join(__dirname,"extract.js"),"utf-8");expect(c).not.toMatch("comment should be extracted extract-test.1"),expect(c).not.toMatch("comment should be stripped extract-test.2"),expect(c).not.toMatch("comment should be extracted extract-test.3"),expect(c).not.toMatch("comment should be stripped extract-test.4"),expect(c).toMatch("/*! For license information please see extract.js.LICENSE */")})),it("should pass mangle options",(function(){const t=o(/*! fs */747),e=o(/*! path */622),c=t.readFileSync(e.join(__dirname,"ie8.js"),"utf-8");expect(c).toMatch(/\.exports=function\((\w)\)\{return function\((\w)\)\{try\{\1\(\)\}catch\(\1\)\{\2\(\1\)\}\}\}/)})),it("should pass compress options",(function(){const t=o(/*! fs */747),e=o(/*! path */622),c=t.readFileSync(e.join(__dirname,"compress.js"),"utf-8");expect(c).toMatch(".exports=function(){console.log(4),console.log(6),console.log(4),console.log(7)}")})),Math.random()<0&&o(/*! ./test.js */393)})();
         |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     ^

      at test/js/config/plugins/terser-plugin/bundle0.js:30:1557
      at Object.<anonymous> (test/helpers/createLazyTestEnv.js:12:13)

FAIL test/StatsTestCases.test.js (15.742s)
  ● StatsTestCases › should print correct stats for filter-warnings

    expect(received).toMatchSnapshot()

    Snapshot name: `StatsTestCases should print correct stats for filter-warnings 1`

    - Snapshot
    + Received

    @@ -1,5 +1,9 @@
    + (node:6644) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 unpipe listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit
    + (node:6644) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit
    + (node:6644) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit
    + (node:6644) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 finish listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit
      Hash: c7acc7e9d00613f9def9c7acc7e9d00613f9def9c7acc7e9d00613f9def9c7acc7e9d00613f9def9c7acc7e9d00613f9def9c7acc7e9d00613f9def9c7acc7e9d00613f9def9c7acc7e9d00613f9def9c7acc7e9d00613f9def9c7acc7e9d00613f9def9c7acc7e9d00613f9def9c7acc7e9d00613f9def9c7acc7e9d00613f9def9
      Child undefined:
          Hash: c7acc7e9d00613f9def9
          Time: Xms
          Built at: 1970-04-20 12:42:42

      192 | 					.replace(/(\w)\\(\w)/g, "$1/$2")
      193 | 					.replace(/, additional resolving: Xms/g, "");
    > 194 | 				expect(actual).toMatchSnapshot();
          | 				               ^
      195 | 				if (testConfig.validate) testConfig.validate(stats, stderr.toString());
      196 | 				done();
      197 | 			});

      at test/StatsTestCases.test.js:194:20
      at finalCallback (lib/MultiCompiler.js:5312:16)
      at lib/MultiCompiler.js:5389:9
      at done (node_modules/neo-async/async.js:2931:13)
      at runCompilers (lib/MultiCompiler.js:5050:16)
      at lib/MultiCompiler.js:5083:11
      at lib/MultiCompiler.js:5370:11
      at finalCallback (lib/Compiler.js:9473:9)
      at lib/Compiler.js:9732:22
      at Hook.eval [as callAsync] (eval at create (node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)

 › 1 snapshot failed.
Snapshot Summary
 › 1 snapshot failed from 1 test suite. Inspect your code changes or run `
Test Suites: 2 failed, 1 passed, 3 total
Tests:       3 failed, 7 skipped, 2821 passed, 2831 total
Snapshots:   1 failed, 104 passed, 105 total
Time:        46.806s

See complete report here.

@alexander-akait
Copy link
Member

alexander-akait commented Jan 28, 2020

license files now have the txt extension, some tests need to be updated

@sokra
Copy link
Member

sokra commented Jan 29, 2020

I can't merge this as this problem is still not fixed:

MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 unpipe listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit

@dependabot-preview
Copy link
Contributor Author

Superseded by #10323.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/terser-webpack-plugin-2.3.3 branch January 30, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file PR: CI-not-ok PR: unreviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants