Refactor defaulting #10401
Merged
Refactor defaulting #10401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
sokra
force-pushed
the
refactor/defaults
branch
2 times, most recently
from
b730647
to
0f046a3
Compare
Apply defaults after plugins are applied to allow plugins to feature their own defaults. This allows to make preset plugins.
sokra
force-pushed
the
refactor/defaults
branch
from
0f046a3
to
683e867
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
I've created an issue to document this in webpack/webpack.js.org. |
|
Wow that's really a cool idea 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split options defaulting in normalization and defaults
Apply defaults after plugins are applied to allow plugins to feature their own defaults.
This allows to make preset plugins.
What kind of change does this PR introduce?
refactoring, feature
Did you add tests for your changes?
TODO
Does this PR introduce a breaking change?
yes
What needs to be documented once your changes are merged?
plugins may apply defaults to the configuration. Configuration is normalized before plugins are applied. Core defaults are applied after plugins has been applied.
cc @jantimon