Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return preset normal for stats true #11090

Merged
merged 4 commits into from
Jun 25, 2020
Merged

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
closes #11072

Did you add tests for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@snitin315 snitin315 changed the title feat: return preset normal for stats true return preset normal for stats true Jun 25, 2020
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test. test/Defaults.test.js has some tests for normalization, add one there

@snitin315 snitin315 marked this pull request as ready for review June 25, 2020 09:57
@webpack-bot
Copy link
Contributor

The minimum test ratio has been reached. Thanks!

@sokra sokra merged commit 75bf091 into webpack:master Jun 25, 2020
@sokra
Copy link
Member

sokra commented Jun 25, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: option stats is not compiling value true correctly
3 participants