added tests around minified runtime versions of semver functions #11280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #11271 I wrote some tests to help try an work out what was happening with the runtime versions of the semver functions. I offered to add them to the test suite in that PR and @sokra suggested as a seperate PR to not hold up the bug fix getting through.
There's some pretty nasty code in here to generate the functions with a dummy
RuntimeTemplate
and evaluate the functions to be runnable in the test suite, so I'm happy to take suggestions on how to make those parts less nasty. I did investigate usingnew Function(...)
instead ofeval
, but there was an issue with accessing other functions in the module's scope when executing it in a NodeJS environment (some details in the MSDN docs).What kind of change does this PR introduce?
Tests only.
Did you add tests for your changes?
I only added tests.
Does this PR introduce a breaking change?
No.
What needs to be documented once your changes are merged?
Nothing.